Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Cargo update; and support converting *.xz to *.gz when promoting a release. #31

Merged
merged 2 commits into from
Jan 29, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Jan 27, 2018

A follow-up to rust-lang/rust#45002.

The first commit ab4c52f just updates all dependencies to their latest version, and also eliminated the rustc-serialize dependency from rbars.

The second commit 99de474 adds the capability of creating a *.gz from a *.xz when the former is missing. This allows us to skip creating *.gz from the Rust CI, and thus save ~50% in S3 and AppVeyor space usage. The trade-off is release generation will take longer (recompression takes ~1 MB/s on my laptop).

This is the first step to stop uploading *.gz into the internal S3 bucket.
@alexcrichton
Copy link
Member

Thanks!

It is actually sort of nice that the release takes ~40m right now, most of that being network time. We have such a huge amount of artifacts though I'd imagine that this could take quite awhile... The machine we do releases on I think is also a pretty small instance :(

That being said I'm fine having this as a backstop? I think I'd prefer that we don't turn off gz tarball generation just yet, but perhaps we could land this and have that in our back pocket for emergencies? How's that sound?

@kennytm
Copy link
Member Author

kennytm commented Jan 29, 2018

I think I'd prefer that we don't turn off gz tarball generation just yet, but perhaps we could land this and have that in our back pocket for emergencies?

Yeah sure, we could proceed whenever comfortable 🙂

@alexcrichton
Copy link
Member

Ok!

@alexcrichton alexcrichton merged commit e70e7b2 into master Jan 29, 2018
@alexcrichton alexcrichton deleted the xz-to-gz branch January 29, 2018 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants