Skip to content

Commit

Permalink
Run cargo dev bless
Browse files Browse the repository at this point in the history
  • Loading branch information
hkmatsumoto committed Jan 7, 2021
1 parent 6b5f049 commit 70a8631
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 16 deletions.
8 changes: 7 additions & 1 deletion tests/ui/needless_question_mark.fixed
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
// run-rustfix

#![warn(clippy::needless_question_mark)]
#![allow(clippy::needless_return, clippy::unnecessary_unwrap, dead_code, unused_must_use)]
#![allow(
clippy::needless_return,
clippy::unnecessary_unwrap,
clippy::upper_case_acronyms,
dead_code,
unused_must_use
)]
#![feature(custom_inner_attributes)]

struct TO {
Expand Down
8 changes: 7 additions & 1 deletion tests/ui/needless_question_mark.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
// run-rustfix

#![warn(clippy::needless_question_mark)]
#![allow(clippy::needless_return, clippy::unnecessary_unwrap, dead_code, unused_must_use)]
#![allow(
clippy::needless_return,
clippy::unnecessary_unwrap,
clippy::upper_case_acronyms,
dead_code,
unused_must_use
)]
#![feature(custom_inner_attributes)]

struct TO {
Expand Down
28 changes: 14 additions & 14 deletions tests/ui/needless_question_mark.stderr
Original file line number Diff line number Diff line change
@@ -1,85 +1,85 @@
error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:17:12
--> $DIR/needless_question_mark.rs:23:12
|
LL | return Some(to.magic?);
| ^^^^^^^^^^^^^^^ help: try: `to.magic`
|
= note: `-D clippy::needless-question-mark` implied by `-D warnings`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:25:12
--> $DIR/needless_question_mark.rs:31:12
|
LL | return Some(to.magic?)
| ^^^^^^^^^^^^^^^ help: try: `to.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:30:5
--> $DIR/needless_question_mark.rs:36:5
|
LL | Some(to.magic?)
| ^^^^^^^^^^^^^^^ help: try: `to.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:35:21
--> $DIR/needless_question_mark.rs:41:21
|
LL | to.and_then(|t| Some(t.magic?))
| ^^^^^^^^^^^^^^ help: try: `t.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:44:9
--> $DIR/needless_question_mark.rs:50:9
|
LL | Some(t.magic?)
| ^^^^^^^^^^^^^^ help: try: `t.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:49:12
--> $DIR/needless_question_mark.rs:55:12
|
LL | return Ok(tr.magic?);
| ^^^^^^^^^^^^^ help: try: `tr.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:56:12
--> $DIR/needless_question_mark.rs:62:12
|
LL | return Ok(tr.magic?)
| ^^^^^^^^^^^^^ help: try: `tr.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:60:5
--> $DIR/needless_question_mark.rs:66:5
|
LL | Ok(tr.magic?)
| ^^^^^^^^^^^^^ help: try: `tr.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:64:21
--> $DIR/needless_question_mark.rs:70:21
|
LL | tr.and_then(|t| Ok(t.magic?))
| ^^^^^^^^^^^^ help: try: `t.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:72:9
--> $DIR/needless_question_mark.rs:78:9
|
LL | Ok(t.magic?)
| ^^^^^^^^^^^^ help: try: `t.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:79:16
--> $DIR/needless_question_mark.rs:85:16
|
LL | return Ok(t.magic?);
| ^^^^^^^^^^^^ help: try: `t.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:132:9
--> $DIR/needless_question_mark.rs:138:9
|
LL | Ok(to.magic?) // should be triggered
| ^^^^^^^^^^^^^ help: try: `to.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:148:9
--> $DIR/needless_question_mark.rs:154:9
|
LL | Some(to.magic?) // should be triggered
| ^^^^^^^^^^^^^^^ help: try: `to.magic`

error: Question mark operator is useless here
--> $DIR/needless_question_mark.rs:156:9
--> $DIR/needless_question_mark.rs:162:9
|
LL | Ok(to.magic?) // should be triggered
| ^^^^^^^^^^^^^ help: try: `to.magic`
Expand Down

0 comments on commit 70a8631

Please sign in to comment.