not lint when DEREF_ADDROF is triggered

rust-lang · May 26, 2022 · d3f53e6 · d3f53e6
1 parent 3372515
commit d3f53e6
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/clippy_lints/src/borrow_deref_ref.rs b/clippy_lints/src/borrow_deref_ref.rs
@@ -63,18 +63,18 @@ impl LateLintPass<'_> for BorrowDerefRef {
             then{
 
                 if let Some(parent_expr) = get_parent_expr(cx, e){
+                    if matches!(parent_expr.kind, ExprKind::Unary(UnOp::Deref, ..)) &&
+                       !is_lint_allowed(cx, DEREF_ADDROF, parent_expr.hir_id) {
+                        return;
+                    }
+
                     // modification to `&mut &*x` is different from `&mut x`
                     if matches!(deref_target.kind, ExprKind::Path(..)
-                                                | ExprKind::Field(..)
-                                                | ExprKind::Index(..)
-                                                | ExprKind::Unary(UnOp::Deref, ..)) {
-                        if matches!(parent_expr.kind, ExprKind::AddrOf(_, Mutability::Mut, _)) {
-                            return;
-                        }
-                        if matches!(parent_expr.kind, ExprKind::Unary(UnOp::Deref, ..)) &&
-                           !is_lint_allowed(cx, DEREF_ADDROF, parent_expr.hir_id) {
-                            return;
-                        }
+                                             | ExprKind::Field(..)
+                                             | ExprKind::Index(..)
+                                             | ExprKind::Unary(UnOp::Deref, ..))
+                     && matches!(parent_expr.kind, ExprKind::AddrOf(_, Mutability::Mut, _)) {
+                       return;
                     }
                 }