Skip to content

False positive on boxed_local for Box<Self> parameters #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leoyvens opened this issue Jul 27, 2016 · 3 comments
Closed

False positive on boxed_local for Box<Self> parameters #1123

leoyvens opened this issue Jul 27, 2016 · 3 comments
Labels
C-bug Category: Clippy is not doing the correct thing T-middle Type: Probably requires verifiying types

Comments

@leoyvens
Copy link

Some traits such as FnBox define methods that take Box<Self>. Implementing such a method will incorrectly trigger the boxed_local lint.

@llogiq
Copy link
Contributor

llogiq commented Aug 29, 2016

See also #916

@mcarton mcarton added C-bug Category: Clippy is not doing the correct thing T-middle Type: Probably requires verifiying types labels Sep 4, 2016
@0ndorio
Copy link
Contributor

0ndorio commented Jun 17, 2018

I think I hit this old issue with the following playground example [1]. I know that self: Box<Self> as function parameter is a bit odd, but the trait implementation can't change much about the trait definition.

[1] https://play.rust-lang.org/?gist=5720b0cda84efeb89752c7491acd40ab&version=stable&mode=debug

@phansch
Copy link
Member

phansch commented Oct 16, 2018

Fixed via #3321 (feel free to re-open if it's still a problem)

@phansch phansch closed this as completed Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing T-middle Type: Probably requires verifiying types
Projects
None yet
Development

No branches or pull requests

5 participants