Skip to content

Avoid linting boxed_local on trait implementations. #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

0ndorio
Copy link
Contributor

@0ndorio 0ndorio commented Oct 15, 2018

Adds a check to avoid linting boxed_local on trait implementations. This should fix the issues #916, #1123 and #1478.

It also introduces the missing tests/ui/escape_analysis.stderr output file to enable the the related regression tests.

@0ndorio
Copy link
Contributor Author

0ndorio commented Oct 15, 2018

Seems like the fail of appveyor is based on the following issue in reqwest 0.9.2 (seanmonstar/reqwest#371).

@timvisee
Copy link
Contributor

timvisee commented Oct 15, 2018

@0ndorio The issue was caused by a broken mime crate version. It has been yanked, and a new version has been pushed.

Running cargo update and building again should resolve the error.

@phansch phansch closed this Oct 15, 2018
@phansch phansch reopened this Oct 15, 2018
@phansch
Copy link
Member

phansch commented Oct 15, 2018

I triggered a new build, so that should should be working now.

@oli-obk oli-obk merged commit 6ae89c4 into rust-lang:master Oct 16, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Oct 16, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants