collapsible_else_if disregard platform code in else branch

[pronebird]

Summary

Without much context, I have the following code:

if connectivity.is_offline() {
    NextTunnelState::SameState(self)
} else {
    #[cfg(any(target_os = "linux", target_os = "macos", target_os = "windows"))]
    Self::reset_dns(shared_state).await;

    if self.reconnect {
        NextTunnelState::NewState(ConnectingState::enter(0, self.selected_gateways, shared_state).await)
    } else {
        NextTunnelState::NewState(DisconnectedState::enter(None, shared_state).await)
    }
}

When compiling for aarch64-apple-ios, clippy suggests to collapse the else block disregarding the platform code:

warning: this `else { if .. }` block can be collapsed
   --> crates/nym-vpn-lib/src/tunnel_state_machine/states/offline_state.rs:143:24
    |
143 |                   } else {
    |  ________________________^
144 | |                     #[cfg(any(target_os = "linux", target_os = "macos", target_os = "windows"))]
145 | |                     Self::reset_dns(shared_state).await;
...   |
152 | |                 }
    | |_________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
    = note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
    |
143 ~                 } else if self.reconnect {
144 +                     NextTunnelState::NewState(ConnectingState::enter(0, self.selected_gateways, shared_state).await)
145 +                 } else {
146 +                     NextTunnelState::NewState(DisconnectedState::enter(None, shared_state).await)
147 +                 }

Which would result into code duplication which I am trying to avoid. (I do not mind nested if)

Lint Name

No response

Reproducer

I tried this code:

<code>

I saw this happen:

<output>

I expected to see this happen:

Version

Additional Labels

No response

[samueltardieu]

@rustbot label +I-suggestion-causes-bug

[relaxcn]

I think this is because when the code is compiled on aarch64-apple-ios platform, the conditionally compiled statement:

    #[cfg(any(target_os = "linux", target_os = "macos", target_os = "windows"))]
    Self::reset_dns(shared_state).await;

is not in the HIR data but AST data.

Maybe we need some mechanism to allow LateLintPass's lint to obtain the corresponding AST data.

[profetia]

For now it is possible to tokenize the sources in between to fix this, but I doubt if it is a clean solution.