Lint casting integers to pointers

[oli-obk]

rust-lang/rust#45527 gives us std::ptr::dangling which allows replacing 1 as _ with std::ptr::dangling(). Once that is stable, it should be a warn lint. Until then an allow lint is ok.

Should probably live together with the zero_ptr lint

[Rua]

Is anyone still interested in implementing this? Even if there is no fix that Clippy can propose, just giving the user the ability to track down such casts is already useful. Note that such casts create a pointer with no provenance, which can be particularly objectionable for future development of Rust code.

[aaron-ang]

@Rua interested

[aaron-ang]

@rustbot claim

[aaron-ang]

should I create a separate lint since zero_ptr is associated with null ptr, whereas a dangling pointer can take on any value if I'm not wrong?

[Rua]

They should probably be separate, because the fix for them is different. The zero case can be fixed with ptr::null, but a nonzero pointer needs a different fix (e.g. the newly-stabilised pointer provenance APIs) and also has a different significance due to said provenance.