You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a list of failing tests caused by rust-lang/rust#52467 and the culprits.
ui/derive.rs: The linted span is Hash as the argument of #[derive(Hash)] which gets recognized as an external macro and therefore this won't get linted.
relevant diff of stderr
-error: you are deriving `Hash` but have implemented `PartialEq` explicitly
- --> $DIR/derive.rs:17:10
- |
-17 | #[derive(Hash)]
- | ^^^^
- |
- = note: #[deny(derive_hash_xor_eq)] on by default
-note: `PartialEq` implemented here
- --> $DIR/derive.rs:20:1
- |
-20 | / impl PartialEq for Bar {
-21 | | fn eq(&self, _: &Bar) -> bool { true }
-22 | | }
- | |_^
-
-error: you are deriving `Hash` but have implemented `PartialEq` explicitly
- --> $DIR/derive.rs:24:10
- |
-24 | #[derive(Hash)]
- | ^^^^
- |
-note: `PartialEq` implemented here
- --> $DIR/derive.rs:27:1
- |
-27 | / impl PartialEq<Baz> for Baz {
-28 | | fn eq(&self, _: &Baz) -> bool { true }
-29 | | }
- | |_^
-
...
-error: aborting due to 7 previous errors
+error: aborting due to 5 previous errors
ui/print.rs: The linted spans are arguments of external macro calls.
relevant diff of stderr
-error: use of `Debug`-based formatting
- --> $DIR/print.rs:13:27
- |
-13 | write!(f, "{:?}", 43.1415)
- | ^^^^^^^
- |
- = note: `-D use-debug` implied by `-D warnings`
-
-error: use of `Debug`-based formatting
- --> $DIR/print.rs:30:26
- |
-30 | print!("Hello {:?}", "World");
- | ^^^^^^^
-
-error: use of `Debug`-based formatting
- --> $DIR/print.rs:32:27
- |
-32 | print!("Hello {:#?}", "#orld");
- | ^^^^^^^
-
...
-error: aborting due to 8 previous errors
+error: aborting due to 5 previous errors
ui/unicode.rs: The linted spans are arguments of external macro calls.
relevant diff of stderr
-error: zero-width space detected
- --> $DIR/unicode.rs:6:12
- |
-6 | print!("Here >< is a ZWS, and another");
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- |
- = note: `-D zero-width-space` implied by `-D warnings`
- = help: Consider replacing the string with:
- ""Here >/u{200B}< is a ZWS, and /u{200B}another""
-
-error: non-nfc unicode sequence detected
- --> $DIR/unicode.rs:12:12
- |
-12 | print!("̀àh?");
- | ^^^^^
- |
- = note: `-D unicode-not-nfc` implied by `-D warnings`
- = help: Consider replacing the string with:
- ""̀àh?""
-
-error: literal non-ASCII character detected
- --> $DIR/unicode.rs:18:12
- |
-18 | print!("Üben!");
- | ^^^^^^^
- |
- = note: `-D non-ascii-literal` implied by `-D warnings`
- = help: Consider replacing the string with:
- ""/u{dc}ben!""
-
-error: aborting due to 3 previous errors
ui/for_loop.rs: The linted spans are ranges, which get recognized as external macros.
relevant diff of stderr
-error: the loop variable `i` is only used to index `vec`.
- --> $DIR/for_loop.rs:86:14
- |
-86 | for i in 0..vec.len() {
- | ^^^^^^^^^^^^
- |
- = note: `-D needless-range-loop` implied by `-D warnings`
-help: consider using an iterator
- |
-86 | for <item> in &vec {
- | ^^^^^^ ^^^^
-
-error: the loop variable `i` is only used to index `vec`.
- --> $DIR/for_loop.rs:95:14
- |
-95 | for i in 0..vec.len() {
- | ^^^^^^^^^^^^
-help: consider using an iterator
- |
-95 | for <item> in &vec {
- | ^^^^^^ ^^^^
-
-error: the loop variable `j` is only used to index `STATIC`.
- --> $DIR/for_loop.rs:100:14
- |
-100 | for j in 0..4 {
- | ^^^^
-help: consider using an iterator
- |
-100 | for <item> in STATIC.iter().take(4) {
- | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^
-
-error: the loop variable `j` is only used to index `CONST`.
- --> $DIR/for_loop.rs:104:14
- |
-104 | for j in 0..4 {
- | ^^^^
-help: consider using an iterator
- |
-104 | for <item> in CONST.iter().take(4) {
- | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^
-
-error: the loop variable `i` is used to index `vec`
- --> $DIR/for_loop.rs:108:14
- |
-108 | for i in 0..vec.len() {
- | ^^^^^^^^^^^^
-help: consider using an iterator
- |
-108 | for (i, <item>) in vec.iter().enumerate() {
- | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^
-
-error: the loop variable `i` is only used to index `vec2`.
- --> $DIR/for_loop.rs:116:14
- |
-116 | for i in 0..vec.len() {
- | ^^^^^^^^^^^^
-help: consider using an iterator
- |
-116 | for <item> in vec2.iter().take(vec.len()) {
- | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: the loop variable `i` is only used to index `vec`.
- --> $DIR/for_loop.rs:120:14
- |
-120 | for i in 5..vec.len() {
- | ^^^^^^^^^^^^
-help: consider using an iterator
- |
-120 | for <item> in vec.iter().skip(5) {
- | ^^^^^^ ^^^^^^^^^^^^^^^^^^
-
-error: the loop variable `i` is only used to index `vec`.
- --> $DIR/for_loop.rs:124:14
- |
-124 | for i in 0..MAX_LEN {
- | ^^^^^^^^^^
-help: consider using an iterator
- |
-124 | for <item> in vec.iter().take(MAX_LEN) {
- | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: the loop variable `i` is only used to index `vec`.
- --> $DIR/for_loop.rs:132:14
- |
-132 | for i in 5..10 {
- | ^^^^^
-help: consider using an iterator
- |
-132 | for <item> in vec.iter().take(10).skip(5) {
- | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: the loop variable `i` is used to index `vec`
- --> $DIR/for_loop.rs:140:14
- |
-140 | for i in 5..vec.len() {
- | ^^^^^^^^^^^^
-help: consider using an iterator
- |
-140 | for (i, <item>) in vec.iter().enumerate().skip(5) {
- | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: the loop variable `i` is used to index `vec`
- --> $DIR/for_loop.rs:144:14
- |
-144 | for i in 5..10 {
- | ^^^^^
-help: consider using an iterator
- |
-144 | for (i, <item>) in vec.iter().enumerate().take(10).skip(5) {
- | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: this range is empty so this for loop will never run
- --> $DIR/for_loop.rs:148:14
- |
-148 | for i in 10..0 {
- | ^^^^^
- |
- = note: `-D reverse-range-loop` implied by `-D warnings`
-help: consider using the following if you are attempting to iterate over this range in reverse
- |
-148 | for i in (0..10).rev() {
- | ^^^^^^^^^^^^^
-
-error: this range is empty so this for loop will never run
- --> $DIR/for_loop.rs:156:14
- |
-156 | for i in MAX_LEN..0 {
- | ^^^^^^^^^^
-help: consider using the following if you are attempting to iterate over this range in reverse
- |
-156 | for i in (0..MAX_LEN).rev() {
- | ^^^^^^^^^^^^^^^^^^
-
-error: this range is empty so this for loop will never run
- --> $DIR/for_loop.rs:160:14
- |
-160 | for i in 5..5 {
- | ^^^^
-
-error: this range is empty so this for loop will never run
- --> $DIR/for_loop.rs:185:14
- |
-185 | for i in 10..5 + 4 {
- | ^^^^^^^^^
-help: consider using the following if you are attempting to iterate over this range in reverse
- |
-185 | for i in (5 + 4..10).rev() {
- | ^^^^^^^^^^^^^^^^^
-
-error: this range is empty so this for loop will never run
- --> $DIR/for_loop.rs:189:14
- |
-189 | for i in (5 + 2)..(3 - 1) {
- | ^^^^^^^^^^^^^^^^
-help: consider using the following if you are attempting to iterate over this range in reverse
- |
-189 | for i in ((3 - 1)..(5 + 2)).rev() {
- | ^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: this range is empty so this for loop will never run
- --> $DIR/for_loop.rs:193:14
- |
-193 | for i in (5 + 2)..(8 - 1) {
- | ^^^^^^^^^^^^^^^^
-
-error: it looks like you're manually copying between slices
- --> $DIR/for_loop.rs:462:14
- |
-462 | for i in 0..src.len() {
- | ^^^^^^^^^^^^ help: try replacing the loop by: `dst[..src.len()].clone_from_slice(&src[..])`
- |
- = note: `-D manual-memcpy` implied by `-D warnings`
-
-error: it looks like you're manually copying between slices
- --> $DIR/for_loop.rs:467:14
- |
-467 | for i in 0..src.len() {
- | ^^^^^^^^^^^^ help: try replacing the loop by: `dst[10..(src.len() + 10)].clone_from_slice(&src[..])`
-
-error: it looks like you're manually copying between slices
- --> $DIR/for_loop.rs:472:14
- |
-472 | for i in 0..src.len() {
- | ^^^^^^^^^^^^ help: try replacing the loop by: `dst[..src.len()].clone_from_slice(&src[10..])`
-
-error: it looks like you're manually copying between slices
- --> $DIR/for_loop.rs:477:14
- |
-477 | for i in 11..src.len() {
- | ^^^^^^^^^^^^^ help: try replacing the loop by: `dst[11..src.len()].clone_from_slice(&src[(11 - 10)..(src.len() - 10)])`
-
-error: it looks like you're manually copying between slices
- --> $DIR/for_loop.rs:482:14
- |
-482 | for i in 0..dst.len() {
- | ^^^^^^^^^^^^ help: try replacing the loop by: `dst.clone_from_slice(&src[..dst.len()])`
-
-error: it looks like you're manually copying between slices
- --> $DIR/for_loop.rs:495:14
- |
-495 | for i in 10..256 {
- | ^^^^^^^
-help: try replacing the loop by
- |
-495 | for i in dst[10..256].clone_from_slice(&src[(10 - 5)..(256 - 5)])
-496 | dst2[(10 + 500)..(256 + 500)].clone_from_slice(&src[10..256]) {
- |
-
-error: it looks like you're manually copying between slices
- --> $DIR/for_loop.rs:507:14
- |
-507 | for i in 10..LOOP_OFFSET {
- | ^^^^^^^^^^^^^^^ help: try replacing the loop by: `dst[(10 + LOOP_OFFSET)..(LOOP_OFFSET + LOOP_OFFSET)].clone_from_slice(&src[(10 - some_var)..(LOOP_OFFSET - some_var)])`
-
-error: it looks like you're manually copying between slices
- --> $DIR/for_loop.rs:520:14
- |
-520 | for i in 0..src_vec.len() {
- | ^^^^^^^^^^^^^^^^ help: try replacing the loop by: `dst_vec[..src_vec.len()].clone_from_slice(&src_vec[..])`
-
-error: it looks like you're manually copying between slices
- --> $DIR/for_loop.rs:547:14
- |
-547 | for i in 0..src.len() {
- | ^^^^^^^^^^^^ help: try replacing the loop by: `dst[..src.len()].clone_from_slice(&src[..])`
-
...
-error: aborting due to 59 previous errors
+error: aborting due to 33 previous errors
ui/needless_range_loop.rs: The linted spans are ranges.
relevant diff of stderr
-error: the loop variable `i` is only used to index `ns`.
- --> $DIR/needless_range_loop.rs:8:14
- |
-8 | for i in 3..10 {
- | ^^^^^
- |
- = note: `-D needless-range-loop` implied by `-D warnings`
-help: consider using an iterator
- |
-8 | for <item> in ns.iter().take(10).skip(3) {
- | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: the loop variable `i` is only used to index `ms`.
- --> $DIR/needless_range_loop.rs:29:14
- |
-29 | for i in 0..ms.len() {
- | ^^^^^^^^^^^
-help: consider using an iterator
- |
-29 | for <item> in &mut ms {
- | ^^^^^^ ^^^^^^^
-
-error: the loop variable `i` is only used to index `ms`.
- --> $DIR/needless_range_loop.rs:35:14
- |
-35 | for i in 0..ms.len() {
- | ^^^^^^^^^^^
-help: consider using an iterator
- |
-35 | for <item> in &mut ms {
- | ^^^^^^ ^^^^^^^
-
-error: aborting due to 3 previous errors
ui/range_plus_minus_one.rs: The linted spans are ranges.
relevant diff of stderr
-error: an inclusive range would be more readable
- --> $DIR/range_plus_minus_one.rs:10:14
- |
-10 | for _ in 0..3+1 { }
- | ^^^^^^ help: use: `0..=3`
- |
- = note: `-D range-plus-one` implied by `-D warnings`
-
-error: an inclusive range would be more readable
- --> $DIR/range_plus_minus_one.rs:13:14
- |
-13 | for _ in 0..1+5 { }
- | ^^^^^^ help: use: `0..=5`
-
-error: an inclusive range would be more readable
- --> $DIR/range_plus_minus_one.rs:16:14
- |
-16 | for _ in 1..1+1 { }
- | ^^^^^^ help: use: `1..=1`
-
-error: an inclusive range would be more readable
- --> $DIR/range_plus_minus_one.rs:22:14
- |
-22 | for _ in 0..(1+f()) { }
- | ^^^^^^^^^^ help: use: `0..=f()`
-
-error: an exclusive range would be more readable
- --> $DIR/range_plus_minus_one.rs:26:13
- |
-26 | let _ = ..=11-1;
- | ^^^^^^^ help: use: `..11`
- |
- = note: `-D range-minus-one` implied by `-D warnings`
-
-error: an exclusive range would be more readable
- --> $DIR/range_plus_minus_one.rs:27:13
- |
-27 | let _ = ..=(11-1);
- | ^^^^^^^^^ help: use: `..11`
-
-error: an inclusive range would be more readable
- --> $DIR/range_plus_minus_one.rs:28:13
- |
-28 | let _ = (f()+1)..(f()+1);
- | ^^^^^^^^^^^^^^^^ help: use: `(f()+1)..=f()`
-
-error: aborting due to 7 previous errors
ui/matches.rs: The linted spans are the match-arms. If they solely consist of an external macro call, like println!, than they won't get linted.
relevant diff of stderr
-error: this `match` has identical arm bodies
- --> $DIR/matches.rs:131:18
- |
-131 | Ok(_) => println!("ok"),
- | ^^^^^^^^^^^^^^
- |
- = note: `-D match-same-arms` implied by `-D warnings`
-note: same as this
- --> $DIR/matches.rs:130:18
- |
-130 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:130:18
- |
-130 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
-error: this `match` has identical arm bodies
- --> $DIR/matches.rs:137:18
- |
-137 | Ok(_) => println!("ok"),
- | ^^^^^^^^^^^^^^
- |
-note: same as this
- --> $DIR/matches.rs:136:18
- |
-136 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:136:18
- |
-136 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
-error: this `match` has identical arm bodies
- --> $DIR/matches.rs:143:18
- |
-143 | Ok(_) => println!("ok"),
- | ^^^^^^^^^^^^^^
- |
-note: same as this
- --> $DIR/matches.rs:142:18
- |
-142 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:142:18
- |
-142 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
-error: this `match` has identical arm bodies
- --> $DIR/matches.rs:150:18
- |
-150 | Ok(_) => println!("ok"),
- | ^^^^^^^^^^^^^^
- |
-note: same as this
- --> $DIR/matches.rs:149:18
- |
-149 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:149:18
- |
-149 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
-error: this `match` has identical arm bodies
- --> $DIR/matches.rs:157:18
- |
-157 | Ok(_) => println!("ok"),
- | ^^^^^^^^^^^^^^
- |
-note: same as this
- --> $DIR/matches.rs:156:18
- |
-156 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:156:18
- |
-156 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
-error: this `match` has identical arm bodies
- --> $DIR/matches.rs:163:18
- |
-163 | Ok(_) => println!("ok"),
- | ^^^^^^^^^^^^^^
- |
-note: same as this
- --> $DIR/matches.rs:162:18
- |
-162 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:162:18
- |
-162 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
-error: this `match` has identical arm bodies
- --> $DIR/matches.rs:169:18
- |
-169 | Ok(_) => println!("ok"),
- | ^^^^^^^^^^^^^^
- |
-note: same as this
- --> $DIR/matches.rs:168:18
- |
-168 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:168:18
- |
-168 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
-error: this `match` has identical arm bodies
- --> $DIR/matches.rs:190:29
- |
-190 | (Ok(_), Some(x)) => println!("ok {}", x),
- | ^^^^^^^^^^^^^^^^^^^^
- |
-note: same as this
- --> $DIR/matches.rs:189:29
- |
-189 | (Ok(x), Some(_)) => println!("ok {}", x),
- | ^^^^^^^^^^^^^^^^^^^^
-note: consider refactoring into `(Ok(x), Some(_)) | (Ok(_), Some(x))`
- --> $DIR/matches.rs:189:29
- |
-189 | (Ok(x), Some(_)) => println!("ok {}", x),
- | ^^^^^^^^^^^^^^^^^^^^
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
-error: this `match` has identical arm bodies
- --> $DIR/matches.rs:205:18
- |
-205 | Ok(_) => println!("ok"),
- | ^^^^^^^^^^^^^^
- |
-note: same as this
- --> $DIR/matches.rs:204:18
- |
-204 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:204:18
- |
-204 | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
...
-error: aborting due to 25 previous errors
+error: aborting due to 16 previous errors
ui/unused_io_amount.rs: The linted spans are calls to external macros
relevant diff of stderr
-error: handle written amount returned or use `Write::write_all` instead
- --> $DIR/unused_io_amount.rs:11:5
- |
-11 | try!(s.write(b"test"));
- | ^^^^^^^^^^^^^^^^^^^^^^^
- |
- = note: `-D unused-io-amount` implied by `-D warnings`
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
-error: handle read amount returned or use `Read::read_exact` instead
- --> $DIR/unused_io_amount.rs:13:5
- |
-13 | try!(s.read(&mut buf));
- | ^^^^^^^^^^^^^^^^^^^^^^^
- |
- = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-
...
-error: aborting due to 6 previous errors
+error: aborting due to 4 previous errors
The text was updated successfully, but these errors were encountered:
This is a list of failing tests caused by rust-lang/rust#52467 and the culprits.
ui/derive.rs: The lintedspanisHashas the argument of#[derive(Hash)]which gets recognized as an external macro and therefore this won't get linted.relevant diff of stderr
ui/print.rs: The lintedspans are arguments of external macro calls.relevant diff of stderr
ui/unicode.rs: The lintedspans are arguments of external macro calls.relevant diff of stderr
ui/for_loop.rs: The lintedspans are ranges, which get recognized as external macros.relevant diff of stderr
ui/needless_range_loop.rs: The lintedspans are ranges.relevant diff of stderr
ui/range_plus_minus_one.rs: The lintedspans are ranges.relevant diff of stderr
ui/matches.rs: The lintedspans are thematch-arms. If they solely consist of an external macro call, likeprintln!, than they won't get linted.relevant diff of stderr
ui/unused_io_amount.rs: The lintedspans are calls to external macrosrelevant diff of stderr
The text was updated successfully, but these errors were encountered: