Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: make lint categories linkable #2973

Closed
matthiaskrgr opened this issue Jul 29, 2018 · 1 comment
Closed

website: make lint categories linkable #2973

matthiaskrgr opened this issue Jul 29, 2018 · 1 comment
Labels
A-website Area: Improving the clippy website E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@matthiaskrgr
Copy link
Member

https://rust-lang-nursery.github.io/rust-clippy/master/index.html

It would be cool to be able to set a link to preselected lint groups like "Perf", maybe something like https://rust-lang-nursery.github.io/rust-clippy/master/index.html?sel=perf and have only the perf lints show up when clicking the link (perf checkbox would be marked).

Once this is done, we can set urls to the respective lint groups in the README.md where all the lint groups are listed. :)

@phansch phansch added A-website Area: Improving the clippy website E-help-wanted Call for participation: Help is requested to fix this issue. labels Jul 29, 2018
@phansch
Copy link
Member

phansch commented Jul 31, 2018

If someone wants to get started on this, the code to touch would be in util/gh-pages/index.html.
The website uses Angular 1.4.12 currently, so the handling of the URL parameters would have to happen at the bottom of the file in the lintList controller, similar to how the lint deeplink is implemented:
https://github.com/rust-lang-nursery/rust-clippy/blob/97840090b78ce1f370c3380e8a703da420fe3a98/util/gh-pages/index.html#L209-L212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-website Area: Improving the clippy website E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Development

No branches or pull requests

2 participants