-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clippy recommends use of unstable Self constructors, which cause an ICE #3567
Labels
C-bug
Category: Clippy is not doing the correct thing
I-suggestion-causes-error
Issue: The suggestions provided by this Lint cause an ICE/error when applied
L-suggestion
Lint: Improving, adding or fixing lint suggestions
Comments
ICE doesn't matter here, it's Rust bug and nightly is fixed already. Currently Clippy reports:
Tools replace To make it work properly only
|
phansch
added
C-bug
Category: Clippy is not doing the correct thing
L-suggestion
Lint: Improving, adding or fixing lint suggestions
labels
Dec 20, 2018
It's the
I'll take a look at this. |
phansch
added
the
I-suggestion-causes-error
Issue: The suggestions provided by this Lint cause an ICE/error when applied
label
Jan 4, 2019
39 tasks
ghost
mentioned this issue
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Category: Clippy is not doing the correct thing
I-suggestion-causes-error
Issue: The suggestions provided by this Lint cause an ICE/error when applied
L-suggestion
Lint: Improving, adding or fixing lint suggestions
This is using clippy
clippy 0.0.212 (2e26fdc2 2018-11-22)
Given this example, clippy will suggest
TestStruct::from_something()
entirely be replaced withSelf()
, which is incorrect, and causes the compiler to ICE due to rust-lang/rust#56611Of note is that VSCode with RLS will offer code actions to automatically do this transformation.
The text was updated successfully, but these errors were encountered: