Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to apply suggestions in tests/ui/get_unwap.rs #3625

Closed
phansch opened this issue Jan 3, 2019 · 0 comments
Closed

Failed to apply suggestions in tests/ui/get_unwap.rs #3625

phansch opened this issue Jan 3, 2019 · 0 comments
Labels
I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied

Comments

@phansch
Copy link
Member

phansch commented Jan 3, 2019

Steps to reproduce:

  1. Add // run-rustfix to the file
  2. Run cargo test && tests/ui/update-all-references.sh && cargo test
  3. It will fail with error: failed to compile fixed code
@phansch phansch added the I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied label Jan 3, 2019
@phansch phansch mentioned this issue Jan 4, 2019
Closed
39 tasks
@ghost ghost mentioned this issue Jan 6, 2019
Merged
bors added a commit that referenced this issue Jan 7, 2019
@bors
Auto merge of #3638 - mikerite:fix-3625, r=oli-obk
81fa266 
Improve `get_unwrap` suggestion

Handle case where a reference is immediately dereferenced.

Fixes #3625
@bors bors closed this as completed in #3638 Jan 7, 2019
flip1995 pushed a commit to flip1995/rust-clippy that referenced this issue Jun 28, 2024
@bors
Auto merge of rust-lang#3625 - Strophox:miri-allocation-fix, r=RalfJung
9dec5d4 
Bugfix `MiriAllocBytes` to guarantee different addresses

Fix in `alloc_bytes.rs` following rust-lang/miri#3526

Currently when an allocation of `size == 0` is requested we return a `std::ptr::without_provenance_mut(align)`, but this means returned `ptr`s may overlap, which breaks things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phansch