compiletest test causes everything to rebuild #4114
Comments
bors
added a commit
that referenced
this issue
May 19, 2019
Fix compile-test from forcing a rebuild. If the `compile-test` test was run, then running a cargo build command immediately after caused everything to be rebuilt. This is because the `compile-test` test was deleting all `.rmeta` files in the target directory. Cargo recently switched to always generating `.rmeta` files (rust-lang/cargo#6883), and when the files are deleted, it thinks it needs to be rebuilt. I am not very familiar with compiletest or clippy, so please take a close look and test this out (with the most recent nightly). In particular, make sure it doesn't revert the fixes from #3380 (it seems to work for me). Also @oli-obk mentioned something related in rust-lang/rust#60190 (comment), and I want to make sure that is addressed as well. Fixes #4114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you run
cargo test --test compile-testand then run it again, everything gets rebuilt (this requires the most recent nightly).This is because of this line:
rust-clippy/tests/compile-test.rs
Line 99 in 0331b95
This deletes all
.rmetafiles. With the recent changes to cargo for pipelining, cargo always generates rmeta files and expects them to not to be deleted.The text was updated successfully, but these errors were encountered: