Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up branches #4745

Closed
hellow554 opened this issue Oct 28, 2019 · 9 comments
Closed

Clean up branches #4745

hellow554 opened this issue Oct 28, 2019 · 9 comments
Labels
A-infra Area: CI issues and issues that require full access for GitHub/CI

Comments

@hellow554
Copy link
Contributor

hellow554 commented Oct 28, 2019

There are currently 45 branches at this repo. Most of them are old and outdated (see staled branches). It would be nice if they can get removed so the git completion looks better (e.g. git checkout <tab>).

@flip1995
Copy link
Member

flip1995 commented Oct 28, 2019

I cleaned up a lot of branches, which PRs got merged, the commits in these branches got merged in another way (another PR, manually pushed, ...) or could be deleted savely for some other reasons (e.g., the modified code doesn't even exist anymore).

There are 6 stale branches left.


Deleted branches:
  • 1.39.0-beta
  • acrichto_lockstep
  • beta-clog
  • clarify-readme
  • doc-visibility
  • eta-reduction-reduced
  • foo
  • get_unwrap
  • impl-trait-fix
  • let-return-fix
  • macro-check-split
  • map-clone-iter
  • miri
  • needless-doc-main
  • oli-obk-patch-1
  • plugincalypse
  • preintern_symbols
  • relicense-rewrite
  • replace_uninitialized
  • rustc
  • rustup
  • rustup-49134
  • servo
  • shadow
  • transmute-collection
  • travis-toolchain

@flip1995 flip1995 added the A-infra Area: CI issues and issues that require full access for GitHub/CI label Oct 28, 2019
@Manishearth
Copy link
Member

I think the stable branch is actually stable-somenumber. as is beta-backport. We should protect those.

A think I tend to do is make empty merge commits to bring these branches into master's git history. Some of them may have already been merged and can be deleted.

@flip1995
Copy link
Member

A think I tend to do is make empty merge commits to bring these branches into master's git history

Ok I think this has already been done with stable, beta1.35, rust-1.34.1. rust-1.31.0 and beta_backport, since these branches are 0 commits ahead of master. (?) stable and rust-1.34.1 are exactly the same.

Should we do this also with the other branches or should we protect them?

@flip1995
Copy link
Member

I just checked and #4109 includes all of the above mentioned branches. So can we delete these branches?

@Manishearth
Copy link
Member

Yes, you can delete those branches as long as their head commit shows in git log.

@flip1995
Copy link
Member

Each HEAD of these branches is in the master, so I deleted them. Except rust-1.31.0, since this branch is protected and I cannot unprotect it.

@Manishearth
Copy link
Member

Deleted.

We should also probably create tags for the final published commit for each rust version.

@flip1995
Copy link
Member

We should also probably create tags for the final published commit for each rust version.

Done. I pushed the tags rust-1.**.* since 1.29.0, when Clippy was added to rustup.

bors added a commit that referenced this issue Oct 28, 2019
Merge backport branches back into master

r? @Manishearth

cc #4745

changelog: none
@flip1995
Copy link
Member

With const-match deleted after #6215 (comment), we now only have branches necessary for CI, release, and deployment in this repo. @rust-lang/clippy please create your own fork and open PRs from there to keep it like this. (If you see the need to create a branch directly in this repo, please make sure to delete it right after the PR is merged or closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infra Area: CI issues and issues that require full access for GitHub/CI
Projects
None yet
Development

No branches or pull requests

3 participants