-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
needless_lifetimes: don't show function body? #5284
Labels
C-enhancement
Category: Enhancement of lints, like adding more cases or adding help messages
good-first-issue
These issues are a good way to get started with Clippy
L-suggestion
Lint: Improving, adding or fixing lint suggestions
Comments
matthiaskrgr
changed the title
needless_lifetimes: don't show function body
needless_lifetimes: don't show function body?
Mar 7, 2020
flip1995
added
L-suggestion
Lint: Improving, adding or fixing lint suggestions
good-first-issue
These issues are a good way to get started with Clippy
C-enhancement
Category: Enhancement of lints, like adding more cases or adding help messages
labels
Mar 9, 2020
rabisg0
added a commit
to rabisg0/rust-clippy
that referenced
this issue
Mar 16, 2020
Changes the span on which the lint is reported to point to only the function return type instead of the entire function body. Fixes rust-lang#5284
bors
added a commit
that referenced
this issue
Mar 20, 2020
Improvement: Don't show function body in needless_lifetimes Changes the span on which the lint is reported to point to only the function return type instead of the entire function body. Fixes #5284 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement
Category: Enhancement of lints, like adding more cases or adding help messages
good-first-issue
These issues are a good way to get started with Clippy
L-suggestion
Lint: Improving, adding or fixing lint suggestions
The generated preview spans the entire function, is this actually necessary?
Could we skip the function body and only show the signature that contains the lifetimes?
Or perhaps limit the span to the function return type instead of the end of the function?:
The text was updated successfully, but these errors were encountered: