Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow many_single_char_names still produces warnings #5521

Closed
bluss opened this issue Apr 24, 2020 · 2 comments · Fixed by #5651
Closed

Allow many_single_char_names still produces warnings #5521

bluss opened this issue Apr 24, 2020 · 2 comments · Fixed by #5651

Comments

@bluss
Copy link
Member

bluss commented Apr 24, 2020

#![allow(clippy::many_single_char_names)] does not seem to suppress the lint, as it should,

It produces warnings like

warning: 6 bindings with single-character names in scope
   --> src\dimension\mod.rs:422:17
    |
422 | fn extended_gcd(a: isize, b: isize) -> (isize, (isize, isize)) {
    |                 ^         ^
...

Lints allowed in the code:

#![allow(
    clippy::many_single_char_names,
    clippy::deref_addrof,
    clippy::unreadable_literal,
    clippy::many_single_char_names
)]

Reproduced at ndarray commit 78bd1d84b9baf26c82c299e3bada43f72aa04614

Clippy version clippy 0.0.212 (6651c1b 2020-04-15)

CI log with failure (clippy at the end) https://travis-ci.org/github/rust-ndarray/ndarray/jobs/678756560

Previous similar issue #3198

@flip1995
Copy link
Member

This will be fixed with #5518

@bluss
Copy link
Member Author

bluss commented Apr 24, 2020

nice!

flip1995 added a commit to flip1995/rust-clippy that referenced this issue Apr 25, 2020
Register redundant_field_names and non_expressive_names as early passes

Fixes rust-lang#5356
Fixes rust-lang#5521

We should move all pre_expansion_passes to early_passes, since they were soft deprecated in the rust compiler IIUC.

changelog: none
@bors bors closed this as completed in fca76de May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment