Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error: unknown doc attribute hide #6832

Closed
cquintana-verbio opened this issue Mar 3, 2021 · 2 comments
Closed

error: unknown doc attribute hide #6832

cquintana-verbio opened this issue Mar 3, 2021 · 2 comments
Labels
C-bug Category: Clippy is not doing the correct thing

Comments

@cquintana-verbio
Copy link

cquintana-verbio commented Mar 3, 2021 •
edited
Loading

We've encountered a possible regression on the latest nightly in our CI pipelines. Clippy does not recognize the pattern #[doc(hide)], such as this one: https://github.com/kubo/rust-oracle/blob/master/src/connection.rs#L854

In the currently stable version, clippy is able to proceed.

I expected to see this happen: Clippy is able to check the code.

Instead, this happened: Clippy compains with:

error: unknown `doc` attribute `hide`

Meta

λ cargo +nightly clippy -V  
clippy 0.1.52 (35dbef2 2021-03-02)

λ rustc -Vv
rustc 1.52.0-nightly (35dbef235 2021-03-02)
binary: rustc
commit-hash: 35dbef235048f9a2939dc20effe083ca483c37ff
commit-date: 2021-03-02
host: x86_64-unknown-linux-gnu
release: 1.52.0-nightly
LLVM version: 11.0.1
@cquintana-verbio cquintana-verbio added the C-bug Category: Clippy is not doing the correct thing label Mar 3, 2021
@giraffate
Copy link
Contributor

It seems to be an enhancement of Rustdoc: rust-lang/rust#82652.

@jyn514
Copy link
Member

jyn514 commented Mar 3, 2021

This is not a clippy bug, it would also happen with rustc. See rust-lang/rust#82702 for the current discussion.

@jyn514 jyn514 mentioned this issue Mar 3, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 3, 2021
@bors
Auto merge of rust-lang#82702 - jyn514:downgrade-err, r=Manishearth
1c77a1f 
Change error about unknown attributes to a warning

Hard errors should go through a future-compatibility phase first, especially since these attributes only have no effect and don't actively cause bugs.

Follow-up to rust-lang#82662. Fixes ecosystem breakage like rust-lang/rust-clippy#6832.

r? `@GuillaumeGomez`
@cquintana-verbio cquintana-verbio mentioned this issue Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: Clippy is not doing the correct thing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Manishearth @giraffate @jyn514 @cquintana-verbio