Lint on loop { continue }

[jonas-schievink]

What it does

loop { continue } is heavily used in the embedded ecosystem to sidestep an LLVM miscompilation. However, nowadays it results in the same MIR and thus LLVM IR as loop {}, and the miscompilation of loop {} has been fixed, so this is unnecessary.

Categories (optional)

• Kind: clippy::style probably, since it's just a confusing way to write loop {}

What is the advantage of the recommended code over the original code

Looks clearer

Drawbacks

None.

Linting on macros that expand to continue; should probably be avoided though.

Example

loop { continue; }

Could be written as:

loop {}

[giraffate]

However, nowadays it results in the same MIR and thus LLVM IR as loop {}, and the miscompilation of loop {} has been fixed, so this is unnecessary.

Is there the related PR or discussion? Just wondering.

[jonas-schievink]

The PRs fixing this are probably linked from somewhere in rust-lang/rust#28728

[camsteffen]

This can be an enhancement of needless_continue.