Replace {assert, debug_assert} using == or != by the _eq or _ne variants

[wooster0]

What it does

It checks for asserts like assert!(1 == 1); and suggests to replace it with assert_eq!(1, 1);.
As far as I know, this is more idiomatic.

Categories (optional)

• Kind: most likely clippy::style or maybe clippy::complexity.

The advantage is idiomacy and consistency/consistent style.
It can also improve readability and the _eq/_ne variants make it much easier to search for specific kind of asserts (no regex for example needed).

Drawbacks

None.

Example

assert!(1 == 1);
assert!(5 != 10);
debug_assert!(1 == 1);
debug_assert!(5 != 10);

Could be written as:

assert_eq!(1, 1);
assert_ne!(5, 10);
debug_assert_eq!(1, 1);
debug_assert_ne!(5, 10);

[alex-700]

@r00ster91 there is a long story about RFC-2011. From the clippy side you can see #641 and #2090. IMHO, nothing happened to change the decision from #2090.

[wooster0]

Ah, so the ultimate goal would be to deprecate assert_eq and assert_ne. I see. I agree with that decision! So the relevant issue here would be rust-lang/rust#44838.