-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic parameter to async function causes ICE #9504
Comments
This is caused by #9424. It looks like the compiler generated call to Thanks for the minimal repro. |
bors
added a commit
that referenced
this issue
Sep 21, 2022
Fix ICE in `unnecessary_to_owned` Fixes #9504 Compiler generated call `into_future` nodes return empty substs which we need when checking it's predicates. Handle this by simply exitting when we encounter one. This change introduces false negatives in place of the ICEs. changelog: [`unnecessary_to_owned`]: fix ICE
This was referenced Dec 29, 2023
bors
added a commit
that referenced
this issue
Dec 29, 2023
Remove mitigations for incorrect node args This change https://github.com/rust-lang/rust/pull/118420/files#r1419874371 adds a missing `write_args` to properly record node args for lang-item calls. Thus, in the `unnecessary_to_owned` lint, this ensures that the `call_generic_args` extracted by `get_callee_generic_args_and_args` are always correct, and we can remove the mitigation for #9504 and #10021 since the root cause has been fixed. I'm not sure if there is other now-unnecessary code that can be removed, but this is the one I found when investigating #11965 (comment). changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Minimal repro:
Output:
cargo +nightly build
succeeds with the same input, as doescargo clippy
(on stable).Version
Error output
Backtrace
The text was updated successfully, but these errors were encountered: