Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat custom enum discriminant values as constants #10008

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Dec 1, 2022

fixes #9882
changelog: All lints: Don't lint in enum discriminant values when the suggestion won't work in a const context

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 1, 2022
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 1, 2022

📌 Commit a1b15f1 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 1, 2022

⌛ Testing commit a1b15f1 with merge e16a8b9...

@bors
Copy link
Contributor

bors commented Dec 1, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing e16a8b9 to master...

@bors bors merged commit e16a8b9 into rust-lang:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP: cast_lossless
4 participants