-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add [permissions_set_readonly_false
] #9702
#10063
Conversation
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for taking this over
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry spotted a couple more things, that'll be it this time though I swear 😄
☔ The latest upstream changes (presumably #10099) made this pull request unmergeable. Please resolve the merge conflicts. |
2ac0463
to
6fd0329
Compare
Great! Thanks again @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Add slight modification on this PR.
changelog: New lint [
permissions_set_readonly_false
]#10063