Revert "Auto merge of #9733 - nbdd0121:master, r=dswij" #10069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
the
S-waiting-on-review
|
Our toolchain rolls have been blocked for over a week due to #10041 . This revert addresses the issue and also includes a regression test to ensure a future fix does not reintroduce the bug. If a fix-forward is preferred. I also opened #10068 to attempt to fix the issue. At least one of these two PRs should not be merged. |
|
r? dswij |
|
☔ The latest upstream changes (presumably #10086) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing in favor of #10086 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 33137dd, reversing changes made to 4326814.