Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mutex_atomic to restriction #10115

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Move mutex_atomic to restriction #10115

merged 2 commits into from
Dec 30, 2022

Conversation

rdrpenguin04
Copy link

@rdrpenguin04 rdrpenguin04 commented Dec 25, 2022 •
edited by xFrednet
Loading

By #4295, the general consensus seems to be that mutex_atomic is not a useful lint in most cases. If anything, it could be useful as a restriction on code that for whatever reason can't use atomics. Keeping it in clippy::nursery is harmful to people attempting to use clippy for soundness.

changelog: Moved [mutex_atomic] to restriction
#10115

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 25, 2022
@flip1995
Copy link
Member

If this lint is moved to restriction at least the documentation should summarize the discussions in the issue, why users of this lint should be careful.

@rdrpenguin04
Copy link
Author

I have added a comment. I'm still not sure "shooting flies with cannons" is correct language for a formal issue description, but I didn't write it, and it's likely another PR's job to decide to replace it.

@flip1995
Copy link
Member

@bors r+

Thanks! The description in the documentation LGTM.

@bors
Copy link
Contributor

bors commented Dec 30, 2022

📌 Commit 0298095 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 30, 2022

⌛ Testing commit 0298095 with merge 6ccd4eb...

@bors
Copy link
Contributor

bors commented Dec 30, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 6ccd4eb to master...

@bors bors merged commit 6ccd4eb into rust-lang:master Dec 30, 2022
@taiki-e taiki-e mentioned this pull request Jan 30, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 4, 2025
@Jarcho
Move mutex_integer to restriction and improve mutex_{integer,atomic} …
75e3a2e 
…docs (#14110)

Similar to #10115 (for
`mutex_atomic`), but for `mutex_integer`.

This also improve docs of `mutex_integer`/`mutex_atomic` (extend known
problems section to mention condvar issue
(#1516) and portability
issue).

changelog: Moved [`mutex_integer`] to `restriction`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rdrpenguin04 @rustbot @flip1995 @bors