[drop_ref
]: don't lint idiomatic in match arm
#10142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10122
As established in issue #9482, it is idiomatic to use a single
drop()
expression in a match arm to achieve a side-effect of a function while discarding its output. This should also apply to cases where the function returns a reference.The change to the lint's code was less than 1 line, because all the heavy lifting was done in PR #9491.
changelog: FP: [
drop_ref
]: No longer lints idiomatic expression inmatch
arms#10142