Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Some suggestions generated by the option_if_let_else lint did not compile #10337

Merged
merged 1 commit into from
May 18, 2023
Merged

Fix: Some suggestions generated by the option_if_let_else lint did not compile #10337

merged 1 commit into from
May 18, 2023

Conversation

EliasHolzmann
Copy link
Contributor

@EliasHolzmann EliasHolzmann commented Feb 12, 2023 •
edited by xFrednet
Loading

This addresses a bug in Clippy where the fix suggestend by the option_if_let_else lint would not compile for Results which have an impure expression in the else branch.

changelog: [option_if_let_else]: Fixed incorrect suggestion for Results
#10337

Fixes #10335.

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 12, 2023
@bors
Copy link
Contributor

bors commented Mar 11, 2023

☔ The latest upstream changes (presumably #10434) made this pull request unmergeable. Please resolve the merge conflicts.

@EliasHolzmann
Copy link
Contributor Author

@flip1995 Did you have an opportunity to review this already? If you're busy, I can assign someone else to review this.

@dswij
Copy link
Member

dswij commented May 15, 2023

Thanks for the patience @EliasHolzmann. I will assign this to myself and review this soon

r? @dswij

@rustbot rustbot assigned dswij and unassigned flip1995 May 15, 2023
dswij
dswij approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for opening the PR together with the issue

@dswij
Copy link
Member

dswij commented May 15, 2023

@bors r+

@bors
Copy link
Contributor

bors commented May 15, 2023

📌 Commit d80ca09 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 18, 2023

⌛ Testing commit d80ca09 with merge 407c352...

@bors
Copy link
Contributor

bors commented May 18, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 407c352 to master...

@bors bors merged commit 407c352 into rust-lang:master May 18, 2023
@EliasHolzmann
Copy link
Contributor Author

Thanks for opening the PR together with the issue

Sure! Thank you for getting this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

option_if_let_else generates wrong suggestion for Results
5 participants
@EliasHolzmann @rustbot @bors @dswij @flip1995