redundant_pattern_matching

[disco07]

This PR try to solve this issue #10726,
but it enter in conflict with another test.

changelog: none

Try to test this:

let _w = match x {
     Some(_) => true,
     _ => false,
};

this happen:

 error: match expression looks like `matches!` macro
   --> $DIR/match_expr_like_matches_macro.rs:21:14
    |
 LL |       let _w = match x {
    |  ______________^
 LL | |         Some(_) => true,
 LL | |         _ => false,
 LL | |     };
    | |_____^ help: try this: `matches!(x, Some(_))`
 
+error: redundant pattern matching, consider using `is_some()`
+  --> $DIR/match_expr_like_matches_macro.rs:21:14
+   |
+LL |       let _w = match x {
+   |  ______________^
+LL | |         Some(_) => true,
+LL | |         _ => false,
+LL | |     };
+   | |_____^ help: try this: `x.is_some()`
+   |
+   = note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`
+

I need some help to fix this. Thanks

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dswij (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[disco07]

@xFrednet can you help me please ?

[xFrednet]

@xFrednet can you help me please ?

Sure, I'm guessing, your question is how to prevent the other lint from triggering in this case? In the test files, you could just use #[allow(other_lint)], but that wouldn't be the ideal solution here, as the user would still see two lints. Instead, you can take a look at is_lint_allowed. In this case, I recommend adding a check to match_expr_like_matches_macro, that suppresses the lint, if redundant_pattern_matching is currently allowed.

Does this explanation make sense? :)

[disco07]

@xFrednet can you help me please ?

Sure, I'm guessing, your question is how to prevent the other lint from triggering in this case? In the test files, you could just use #[allow(other_lint)], but that wouldn't be the ideal solution here, as the user would still see two lints. Instead, you can take a look at is_lint_allowed. In this case, I recommend adding a check to match_expr_like_matches_macro, that suppresses the lint, if redundant_pattern_matching is currently allowed.

Does this explanation make sense? :)

Thank you so much I will try this :-)

[disco07]

@xFrednet Can you check my changes if you have some time please :)
Thanks in advance

[xFrednet]

Sure, I'll take a look at it later today or tomorrow. :)

r? @xFrednet

[xFrednet]

This already looks good overall, I have a few NITs, where I would appreciate it if you could update them. But then it'll be ready to be merged :)

[disco07]

Thanks @xFrednet :)

[xFrednet]

Thank you for the swift update. I still have a NIT when it comes to the tests, but that should be a simple update. Once that is done, we can merge it. Could you also squash your fix commits, to only have one or two?

---

PS, I'll be gone over the weekend, so the next review will be done some time next week :)

[xFrednet]

The Option tests still need some adjustments. Then it should be ready.

Have you seen my request to squash your commits, from the last review?

Could you also squash your fix commits, to only have one or two?

[disco07]

The Option tests still need some adjustments. Then it should be ready.

Have you seen my request to squash your commits, from the last review?

Could you also squash your fix commits, to only have one or two?

I hope I made the right changes this time ;)

[xFrednet]

This version looks good to me, thank you for the PR. I hope you had fun working on Clippy :)

@bors r+

[bors]

📌 Commit 79a8867 has been approved by xFrednet

It is now in the queue for this repository.

[bors]

⌛ Testing commit 79a8867 with merge 9aa84ba...

[bors]

💔 Test failed - checks-action_test

[bors]

@disco07: 🔑 Insufficient privileges: not in try users

[disco07]

@xFrednet I update my PR to add changelog: none

[xFrednet]

No problem :)

@bors retry

[bors]

⌛ Testing commit 79a8867 with merge 22b3196...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 22b3196 to master...