Skip to content

Conversation

@KisaragiEffective
Copy link
Contributor

close #10491

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: [needless_doctest_main]: ignore main() in no_test code fence

@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2023

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 14, 2023
@KisaragiEffective KisaragiEffective changed the title Ignore main() in no_test code fences [needless_doctest_main]: ignore main() in no_test code fences Jun 14, 2023
@xFrednet
Copy link
Contributor

Looks good to me, thank you for the update! :D

@bors r+

@bors
Copy link
Contributor

bors commented Jun 14, 2023

📌 Commit 867bd15 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 14, 2023

⌛ Testing commit 867bd15 with merge 1d0d686...

@bors
Copy link
Contributor

bors commented Jun 14, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 1d0d686 to master...

@bors bors merged commit 1d0d686 into rust-lang:master Jun 14, 2023
@KisaragiEffective KisaragiEffective deleted the ignore_main_in_notest_doc_block branch June 14, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

needless_doctest_main reported even though code block is marked no_test

4 participants