Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lint needless_return in fns across a macro boundary #11173

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

Alexendoo
Copy link
Member

Fixes #11167

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 17, 2023
@Alexendoo Alexendoo force-pushed the needless-return-fn-macro branch from 26901e0 to d24f0d0 Compare July 17, 2023 14:03
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 17, 2023

📌 Commit d24f0d0 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 17, 2023

⌛ Testing commit d24f0d0 with merge 3e0170b...

@bors
Copy link
Contributor

bors commented Jul 17, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 3e0170b to master...

@bors bors merged commit 3e0170b into rust-lang:master Jul 17, 2023
@Alexendoo Alexendoo deleted the needless-return-fn-macro branch July 17, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug ice: needless_return suggestion removes code which isnt there inside macro
4 participants