Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redundant_closure_call]: avoid duplicated async keyword when triggering on closure that returns async block #11363

Merged
merged 5 commits into from
Nov 28, 2023
Merged

[redundant_closure_call]: avoid duplicated async keyword when triggering on closure that returns async block #11363

merged 5 commits into from
Nov 28, 2023

Conversation

KisaragiEffective
Copy link
Contributor

@KisaragiEffective KisaragiEffective commented Aug 20, 2023 •
edited
Loading

close #11357

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: [redundant_closure_call]: avoid duplicated async keyword when triggering on closure that returns async block

@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 20, 2023
llogiq
llogiq reviewed Aug 20, 2023
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to make it work right now. Let's see if the discussion on zulip brings a solution.

@KisaragiEffective KisaragiEffective marked this pull request as ready for review August 22, 2023 14:48
@KisaragiEffective
Copy link
Contributor Author

This PR is ready for review.

@KisaragiEffective KisaragiEffective changed the title [WIP] [redundant_closure_call]: avoid duplicated async keyword when triggering on closure that returns async block [redundant_closure_call]: avoid duplicated async keyword when triggering on closure that returns async block Aug 22, 2023
@bors
Copy link
Contributor

bors commented Sep 25, 2023

☔ The latest upstream changes (presumably #11563) made this pull request unmergeable. Please resolve the merge conflicts.

@KisaragiEffective KisaragiEffective force-pushed the fix_redundant_closure_call_on_closure_returns_async_block branch from ef3f578 to 6e9a997 Compare October 21, 2023 13:45
@KisaragiEffective
Copy link
Contributor Author

rebased.

@y21
Copy link
Member

y21 commented Oct 24, 2023

CI is failing, do you need help with this or is this still a wip?

@KisaragiEffective
Copy link
Contributor Author

KisaragiEffective commented Oct 25, 2023 •
edited
Loading

This is still wip, I think I have reverted necessary commit and break format

@llogiq
Copy link
Contributor

llogiq commented Oct 28, 2023

@rustbot author

@KisaragiEffective Please tell rustbot "review" when you've got the PR ready for review. Or do you need any help going forward?

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 28, 2023
@bors
Copy link
Contributor

bors commented Nov 2, 2023

☔ The latest upstream changes (presumably #11747) made this pull request unmergeable. Please resolve the merge conflicts.

@KisaragiEffective KisaragiEffective marked this pull request as draft November 27, 2023 13:10
@KisaragiEffective KisaragiEffective force-pushed the fix_redundant_closure_call_on_closure_returns_async_block branch from c8fcda3 to 1661e7e Compare November 27, 2023 14:44
@KisaragiEffective
Copy link
Contributor Author

KisaragiEffective commented Nov 27, 2023 •
edited
Loading

Re-implemented on latest master

Could you help me with spawn_on in issue11707::demo? It triggers clippy::double_parens...

@KisaragiEffective
Copy link
Contributor Author

I believe it is handled by 3318249, but still not sure if this is right way to do.

@KisaragiEffective KisaragiEffective marked this pull request as ready for review November 28, 2023 18:47
@KisaragiEffective
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Nov 28, 2023
@llogiq
Copy link
Contributor

llogiq commented Nov 28, 2023

Looks good to me. Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 28, 2023

📌 Commit 0426913 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 28, 2023

⌛ Testing commit 0426913 with merge 57397a5...

@bors
Copy link
Contributor

bors commented Nov 28, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 57397a5 to master...

@bors bors merged commit 57397a5 into rust-lang:master Nov 28, 2023
@KisaragiEffective KisaragiEffective deleted the fix_redundant_closure_call_on_closure_returns_async_block branch February 29, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llogiq llogiq llogiq left review comments

@y21 y21 y21 left review comments

Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redundant_closure_call: suggestion does not work if inner expression is async block
5 participants
@KisaragiEffective @rustbot @bors @y21 @llogiq