Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document conflicting lints #11666

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Document conflicting lints #11666

merged 2 commits into from
Oct 16, 2023

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Oct 13, 2023

Documents the outcome described in #11662 so that the situation can be avoided in the future by other individuals.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2023

r? @flip1995

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 13, 2023
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea documenting this!

book/src/development/adding_lints.md Outdated Show resolved Hide resolved
book/src/development/adding_lints.md Outdated Show resolved Hide resolved
@c410-f3r c410-f3r changed the title Document opposing lints Document conflicting lints Oct 13, 2023
@c410-f3r
Copy link
Contributor Author

@flip1995 Done, thanks for the review.

@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 16, 2023

📌 Commit 8c0870d has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 16, 2023

⌛ Testing commit 8c0870d with merge 387d756...

@bors
Copy link
Contributor

bors commented Oct 16, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 387d756 to master...

@bors bors merged commit 387d756 into rust-lang:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants