-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable vec_box
when using different allocators
#11780
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Clippy 👋. The changes look good to me, there is one small additional tests I would like to see and then we can merge this :D
Looks good to me, thank you for the swift update :D @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fixes #7114
This PR disables the
vec_box
lint when theBox
andVec
use different allocators (but not when they use the same - custom - allocator).For example -
Vec<Box<i32, DummyAllocator>>
will disable the lint, andVec<Box<i32, DummyAllocator>, DummyAllocator>
will not disable the lint.In addition, the applicability of this lint has been changed to
Unspecified
due to the automatic fixes potentially breaking code such as the following:It should be noted that the
if_chain->let-chains
fix has also been applied to this lint, so the diff does contain many changes.changelog: disable
vec_box
lint when using nonstandard allocators