Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Lint: empty_enum_variants_with_brackets #12047

Merged

Conversation

ARandomDev99
Copy link
Contributor

This PR:

  • adds a new early pass lint that checks for enum variants with no fields that were defined using brackets. Category: Restriction
  • adds relevant UI tests for the new lint.

Closes #12007

changelog: New lint: [`empty_enum_variants_with_brackets`]

- Add a new early pass lint.
- Add relevant UI tests.
@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 29, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Dec 30, 2023

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Dec 30, 2023

📌 Commit 5f17188 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 30, 2023

⌛ Testing commit 5f17188 with merge 7f185bd...

@bors
Copy link
Contributor

bors commented Dec 30, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 7f185bd to master...

@bors bors merged commit 7f185bd into rust-lang:master Dec 30, 2023
7 checks passed
Follpvosten pushed a commit to Follpvosten/nix-rust-quickstart that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect Enum Objects with empty attribute body using {}
4 participants