Show duplicate diagnostics in UI tests by default #12374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth rustbot has assigned @Manishearth. Use r? to explicitly pick a reviewer |
rustbot
added
the
S-waiting-on-review
Alexendoo
force-pushed
the
duplicate-diagnostics
branch
from
cefc481 to
ae08cd2
Compare
Alexendoo
force-pushed
the
duplicate-diagnostics
branch
from
ae08cd2 to
733e1d4
Compare
Alexendoo
changed the title
Manishearth
approved these changes
Feb 28, 2024
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
20 tasks
|
Opened an issue, so that the current tests might also get cleaned up over time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated diagnostics can indicate where redundant work is being done, this PR doesn't fix any of that but does indicate in which tests they're occurring for future investigation or to catch issues in future lints
changelog: none