[ptr_as_ptr]: Fix duplicate diagnostics

[Luv-Ray]

Relates to #12379

ptr_as_ptr::check is called twice in clippy_lints/src/casts/mod.rs

---

changelog: [ptr_as_ptr]: Fix duplicate diagnostics

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @blyxyas (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[blyxyas]

LGTM, thanks! ❤️

[blyxyas]

@bors r+

[bors]

📌 Commit c64342c has been approved by blyxyas

It is now in the queue for this repository.

[bors]

⌛ Testing commit c64342c with merge 15f79af...

[bors]

💔 Test failed - checks-action_dev_test

[Luv-Ray]

Sorry that I can't figure out why tests are failed :(
I tried pull auto branch to my local and run:

cargo dev new_lint --name new_early_pass --pass early
cargo dev new_lint --name new_late_pass --pass late
cargo check

and there was no error reported.
Also I can't find any relation in error code and my commit code.
Any help would be appreciated.

[blyxyas]

I'll just rebase and retry CI I guess. I can't seem to replicate the issue either :/
Maybe just a spurious issue? I don't think that this PR in particular has any issue. (At least not regarding to features)

[y21]

Opened a zulip thread: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/proc-macro2.20broken.20dependency/near/433330958

We're using a pinned nightly that's almost 2 weeks old, and it looks like a newer version of proc-macro2 was released yesterday, which makes use of a newly stabilized feature that was not stable in our pinned nightly version, so it broke clippy.
(You should see this error locally if you delete your Cargo.lock, but it shouldn't be caused by this - this also happens on master)

[Luv-Ray]

It reports the error after running cargo update, also the error will be fixed after updating channel from nightly-2024-04-04 to nightly-2024-04-05. Just one day.

[blyxyas]

I'll re-approve this and see if it works. (#12678)
@bors r+

[bors]

📌 Commit da0ae33 has been approved by blyxyas

It is now in the queue for this repository.

[bors]

⌛ Testing commit da0ae33 with merge f5e2501...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing f5e2501 to master...