Skip to content

Conversation

@J-ZhengLi
Copy link
Member

@J-ZhengLi J-ZhengLi commented Jul 11, 2024

fixes: #12973


changelog: make [or_fun_call] recursive.

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2024

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 11, 2024
@J-ZhengLi J-ZhengLi changed the title make [or_fun_call] and [unwrap_or_default] recursive. make [or_fun_call] recursive. Jul 11, 2024
@bors
Copy link
Contributor

bors commented Jul 11, 2024

☔ The latest upstream changes (presumably #13086) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth
Copy link
Member

r? clippy

bit busy

@rustbot rustbot assigned llogiq and unassigned Manishearth Jul 11, 2024
@llogiq
Copy link
Contributor

llogiq commented Jul 12, 2024

Looks good to me. r=me after a rebase.

@bors delegate+

@bors
Copy link
Contributor

bors commented Jul 12, 2024

✌️ @J-ZhengLi, you can now approve this pull request!

If @llogiq told you to "r=me" after making some further change, please make that change, then do @bors r=@llogiq

@J-ZhengLi
Copy link
Member Author

Done~ thanks, @bors r=@llogiq

@bors
Copy link
Contributor

bors commented Jul 13, 2024

📌 Commit cc1bb8f has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 13, 2024

⌛ Testing commit cc1bb8f with merge 1aac778...

@bors
Copy link
Contributor

bors commented Jul 13, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 1aac778 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

or_fun_call misses nested calls

5 participants