Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lintcheck: Support underscores replacement in URL crate names #13148

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

xFrednet
Copy link
Member

The generated URLs use {krate} for the crate name. This works well for the first part of the docs.rs domain, but the second part is actually the root module, which requires a replacement of all dashes with underscores. This PR adds {krate_} for the root module name.

Diff:

 Removed `clippy::needless_borrows_for_generic_args` in `rustls-pemfile` at
-https://docs.rs/rustls-pemfile/2.1.2/src/rustls-pemfile/pemfile.rs.html#194
+https://docs.rs/rustls-pemfile/2.1.2/src/rustls_pemfile/pemfile.rs.html#194

Example before: https://github.com/xFrednet/rust-clippy/actions/runs/10054236377?pr=4
Example after: https://github.com/xFrednet/rust-clippy/actions/runs/10054878594?pr=4


changelog: none

r? @Alexendoo

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 23, 2024
@Alexendoo
Copy link
Member

👍

The ripgrep one is something I didn't think about, binary only crates don't have rustdocs

@bors r+

@bors
Copy link
Contributor

bors commented Jul 23, 2024

📌 Commit 04693a4 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 23, 2024

⌛ Testing commit 04693a4 with merge bd1224d...

@xFrednet
Copy link
Member Author

The ripgrep one is something I didn't think about, binary only crates don't have rustdocs

Huh, now that you say it. I believe that one fails to be converted because the path doesn't contain a src. But I guess it would make sense to link to the GH repos for those binary crates.

@bors
Copy link
Contributor

bors commented Jul 23, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing bd1224d to master...

@bors bors merged commit bd1224d into rust-lang:master Jul 23, 2024
8 checks passed
@xFrednet xFrednet deleted the lintcheck-link-correction-again branch July 23, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants