Skip to content

Conversation

@alex-semenyuk
Copy link
Member

Close #12708
changelog: [string_slice]: trigger lint if expression is reference to &str

@rustbot
Copy link
Collaborator

rustbot commented Aug 18, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 18, 2024
@alex-semenyuk alex-semenyuk changed the title string_slice should detect on Cow Trigger [string_slice] if expression is reference to &str Aug 18, 2024
@y21
Copy link
Member

y21 commented Aug 19, 2024

Nice, thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 19, 2024

📌 Commit 7b7cf44 has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 19, 2024

⌛ Testing commit 7b7cf44 with merge d0e637d...

@bors
Copy link
Contributor

bors commented Aug 19, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing d0e637d to master...

@bors bors merged commit d0e637d into rust-lang:master Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

string_slice should detect on Cow

4 participants