fix: remove unnecessary filter_map usages #13548
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
| cx, | ||
| if name == "filter_map" { | ||
| UNNECESSARY_FILTER_MAP | ||
| } else { | ||
| UNNECESSARY_FIND_MAP | ||
| }, | ||
| expr.span, | ||
| format!("this `.{name}` can be written more simply using `.{sugg}`"), | ||
| format!("this `.{name}` can be written more simply"), | ||
| format!("try replacing with `.{sugg}`"), |
There was a problem hiding this comment.
This doubles the suggestion in the output. Please reduce the text to "try instead" or "replace with".
There was a problem hiding this comment.
@llogiq fixed, thanks!
|
@rustbot ready |
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #12556
(Fixed version of #12766)
changelog: [unnecessary_filter_map]: filter map improvements