Add match-based manual try to clippy::question_mark #13627

GnomedDev · 2024-10-30T00:10:25Z

Closes #10.

changelog: [question_mark]: Now lints for match-based manual try

rustbot · 2024-10-30T00:10:30Z

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

clippy_lints/src/question_mark.rs

tests/ui/question_mark.rs

clippy_lints/src/question_mark.rs

y21

LGTM

y21 · 2024-11-10T16:15:33Z

Hm right, old PRs need to rerun CI with the switch to the merge queue

rustbot assigned y21 Oct 30, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 30, 2024

GnomedDev force-pushed the manual-try branch 2 times, most recently from c33ce3a to 6f27195 Compare October 30, 2024 11:59

samueltardieu reviewed Oct 30, 2024

View reviewed changes

clippy_lints/src/question_mark.rs Outdated Show resolved Hide resolved

clippy_lints/src/question_mark.rs Outdated Show resolved Hide resolved

y21 reviewed Nov 1, 2024

View reviewed changes

GnomedDev force-pushed the manual-try branch from 6f27195 to 0e9290c Compare November 1, 2024 19:34

Add match-based manual try to clippy::question_mark

6205bcf

GnomedDev force-pushed the manual-try branch from 0e9290c to 6205bcf Compare November 1, 2024 19:42

Avoid linting for closures with inferred return types

139bb25

GnomedDev requested a review from y21 November 2, 2024 13:41

y21 approved these changes Nov 10, 2024

View reviewed changes

y21 enabled auto-merge November 10, 2024 16:12

y21 closed this Nov 10, 2024

auto-merge was automatically disabled November 10, 2024 16:15
Pull request was closed

y21 reopened this Nov 10, 2024

y21 added this pull request to the merge queue Nov 10, 2024

Merged via the queue into rust-lang:master with commit f58088b Nov 10, 2024
16 checks passed

GnomedDev deleted the manual-try branch November 10, 2024 17:10

Provide feedback