correct single_match lint suggestion
#13824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lapla-cogito
changed the title
single_match lint that not make incorrect suggestions when comparing with byte string literals.single_match lint that not make incorrect suggestions when comparing with byte string literals
lapla-cogito
changed the title
single_match lint that not make incorrect suggestions when comparing with byte string literalssingle_match lint suggestion
lapla-cogito
force-pushed
the
broken_single_match
branch
from
2d75986 to
7886fee
Compare
|
@lapla-cogito, It seems that there's a merge conflict 🌵 Could you fix that? (After fixing it, squash the commits so that we're still merging only one commit) |
…ng in single_match lint
lapla-cogito
force-pushed
the
broken_single_match
branch
from
7886fee to
e38fa00
Compare
|
@blyxyas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12758
The
single_matchlint makes incorrect suggestions when comparing with byte string literals. There seems to be an issue with the logic that calculates the number of refs when creating suggestions.changelog: [
single_match]: No longer make incorrect suggestions when comparing with byte string literals.