lintcheck: fix table layout #13825
Open
lintcheck: fix table layout #13825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
klensy
changed the title
klensy
commented
Dec 14, 2024
lintcheck/src/json.rs
Outdated
Comment on lines
286
to
277
| | ------------------------------------------ | ------: | ------: | ------: | | ||
| | [`clippy::float_arithmetic`](#user-content-float-arithmetic) | 0 | 0 | 0 |"; | ||
| let expected = "| Lint | Added | Removed | Changed | | ||
| |--------------------------------------------------------------|-------|---------|---------| |
There was a problem hiding this comment.
Don't added back that fancy ---:
There was a problem hiding this comment.
Right alignment is pretty nice for number columns, the markdown is rendered on the summary page e.g. here at https://github.com/rust-lang/rust-clippy/actions/runs/12297760099?pr=13820
I believe the print in the run itself is more for debugging, personally I don't think it's worth adding a dependency for
There was a problem hiding this comment.
Well, added dep, yes, but lintcheck didn't distributed to users and even cached in CI.
klensy
force-pushed
the
lintcheck-tabled
branch
from
1a3cf61 to
90baf7e
Compare
klensy
changed the title
|
r? Alexendoo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes lintcheck output table looks nice. Before:
After https://github.com/rust-lang/rust-clippy/actions/runs/12329727234/job/34414382066?pr=13825:
Spotted at https://github.com/rust-lang/rust-clippy/actions/runs/12297760099/job/34320221594?pr=13820
changelog: none