don't suggest to use cloned for Cow in unnecessary_to_owned
#13853
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lapla-cogito
force-pushed
the
into_owned_cow
branch
2 times, most recently
from
ebc2dfa to
461c834
Compare
lapla-cogito
force-pushed
the
into_owned_cow
branch
from
461c834 to
e0bf121
Compare
|
@lapla-cogito Could you please take a look failed tests |
y21
reviewed
Dec 21, 2024
Comment on lines
+595
to
+596
| LL | cow.into_owned().into_iter() | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `cow.into_owned()` |
There was a problem hiding this comment.
The suggestion works in this specific case, but it doesn't seem like it would work in the general case if the iterator is later used as part of another expression, e.g. for cow.into_owned().into_iter().map(...).collect() the .into_iter() is required. Tbh I don't think we can really suggest anything here for Cow::into_owned and we probably should just not lint at all here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13624
changelog: [
unnecessary_to_owned]: don't suggest to useclonedonCowinunnecessary_to_owned