Skip to content

Move format_push_string and format_collect to pedantic #13894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2025
Merged

Move format_push_string and format_collect to pedantic #13894

merged 2 commits into from
Jan 28, 2025

Conversation

smoelius
Copy link
Contributor

Closes #11434 by moving format_push_string and format_collect to pedantic.

changelog: Move format_push_string and format_collect to pedantic

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2024

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 29, 2024
@smoelius
Copy link
Contributor Author

cc: @y21

Centri3
Centri3 approved these changes Jan 6, 2025
View reviewed changes
@smoelius
Copy link
Contributor Author

@Centri3 I believe I have addressed your comments. Please let me know if anything else is needed. Thank you very much for the review.

Centri3
Centri3 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I'm happy with this. Thanks!

@Centri3 Centri3 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into rust-lang:master with commit e02c885 Jan 28, 2025
11 checks passed
@smoelius smoelius deleted the fps-and-fc-to-padentic branch January 28, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centri3 Centri3 Centri3 approved these changes

Assignees

@Centri3 Centri3

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should format_collect be warn by default?
3 participants
@smoelius @rustbot @Centri3