Extend implicit_clone
to handle to_string
calls
#14177
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put another way, merge
string_to_string
intoimplicit_clone
, as suggested here: #14173 (comment)Note: I wrote this comment:
rust-clippy/clippy_lints/src/methods/implicit_clone.rs
Lines 43 to 45 in 6cdb7f6
Here is the context for why I wrote it: #7978 (comment)
Regardless, it's probably time for the comment to go away. Extending
implicit_clone
to handleto_string
calls yields many hits within Clippy's codebase.changelog: extend
implicit_clone
to handleto_string
calls