Collapse if and if let chains in Clippy itself

[samueltardieu]

This adds a collapse_let_chains config option to the collapsible_if lint. This lint is then applies to Clippy itself. This reduces the level of indentation in Clippy source code in many locations.

The first two commits are from PR #14231, the third one from PR #14233. They must be merged first (or as part of this PR).

If reviewed on GitHub, the last three commits of this PR are best looked at side by side, with whitespace differences turned off.

changelog: none

[rustbot]

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[samueltardieu]

Way too many hits from lintcheck, will double check.

Edit: lintcheck from the CI seems to use clippy.toml from the project, so it sets the collapse-let-chains option. I'll have to find a way to disable this during the lintcheck lint.
Edit: solved through #14233

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
$ git push --force-with-lease

The following commits are merge commits:

• 6fdd6a4

[samueltardieu]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

Those will disappear after the PR it depends on are merged – I'll push with a linear history then, which will contain the same content.

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
$ git push --force-with-lease

The following commits are merge commits (since this message was last posted):

• 36c415b

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
$ git push --force-with-lease

The following commits are merge commits (since this message was last posted):

• 934945b

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
$ git push --force-with-lease

The following commits are merge commits (since this message was last posted):

• ab5d3a3

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
$ git push --force-with-lease

The following commits are merge commits (since this message was last posted):

• 96ea1d6

[samueltardieu]

I'll put this on hold until let chains are stabilized.
r? ghost
@rustbot author

[rustbot]

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[samueltardieu]

Rebased

[samueltardieu]

Rebased

[Centri3]

Just based off a quick look I'm completely ok with merging this before stabilization, we've already had lints like allow_attributes in the past

[samueltardieu]

Just based off a quick look I'm completely ok with merging this before stabilization, we've already had lints like allow_attributes in the past

This needs to be done in steps, as it uses non-default values for options when linting Clippy itself. This requires turning the option back to its default value for lintcheck, which in turn requires the option to be known for lintcheck base to work as expected.

@flip1995 already merged #14231, now #14451 is ready, then I'll assign #14455 to you (first part of this PR), then this one will be ready for review (containing only the latest commit).