macro_use_import: Don't check is attribute comes from expansion #14317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not possible to write a declarative macro, that produces an attribute w/o an item attached to it. This means that the `check_item` will already insert the span in the map, if it came from an expansion. So additionally checking if the macro came from an expansion doesn't add anything here. So the `check_attribute` function, and with that the problematic `attr.span()` call can be completely removed. Fixes rust-lang#14303
rustbot
added
the
S-waiting-on-review
|
On our current master this doesn't ICE, as we're still on an earlier nightly. However I tested this commit on top of #14300 and verified that it actually fixes it. After this is merged, I will do a Clippy->Rust sync to get it into nightly ASAP. |
|
Seems like a trivial fix, nothing wrong with it :) I'd r+ if I could haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to write a declarative macro, that produces an attribute w/o
an item attached to it. This means that the
check_itemwill already insert thespan in the map, if it came from an expansion. So additionally checking if the
macro came from an expansion doesn't add anything here. So the
check_attributefunction, and with that the problematicattr.span()call canbe completely removed.
Fixes #14303
r? @y21
cc @jdonszelmann
changelog: Fix ICE in [
macro_use_import] lint