Add missing tests annotations for ui-internal
#14388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
flip1995
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
The ICE test is by design making Clippy/rustc-driver panic. So my guess it that an ICE can't be printed in JSON format? At least not by causing a direct panic. Maybe replacing the assert(false) that triggers this ICE in the lint implementation with a delayed_span_bug (I think it's called something like this), it might be possible to emit JSON. 🤔
Anyway, let's get this merged first and deal with that later.
|
Ah interesting. Let me give a try. |
is the file you're looking for, if you're wondering :) |
|
I was already on it but it's nice of you. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #11421.
I can't yet make the annotations mandatory because there is an issue with
tests/ui-internal/custom_ice_message.rs: the error message is not emitted as JSON, meaning that we can't match it withui_test. I need to check if it's a bug in rustc or ifui_testneeds to handle this case somehow.changelog: Add missing tests annotations for
ui-internalr? @flip1995