Skip to content

Fix iter_on_single_items FP on function pointers and let stmts #15013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

Fix iter_on_single_items FP on function pointers and let stmts #15013

merged 2 commits into from
Jul 30, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jun 7, 2025 •
edited by rustbot
Loading

Closes #14981

changelog: [iter_on_single_items] fix FP on function pointers and let stmts

@rustbot
Copy link
Collaborator

rustbot commented Jun 7, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 7, 2025
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned Jarcho and unassigned dswij Jun 13, 2025
@profetia
Copy link
Contributor Author

r? samueltardieu

@rustbot rustbot assigned samueltardieu and unassigned Jarcho Jun 30, 2025
@samueltardieu
Copy link
Member

r? clippy

@rustbot rustbot assigned y21 and unassigned samueltardieu Jun 30, 2025
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned blyxyas and unassigned y21 Jul 14, 2025
blyxyas
blyxyas approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️
Sorry for the slow review. The Github diff interface has made reviewing what's actually a few conditions added hellish.

@blyxyas blyxyas added this pull request to the merge queue Jul 30, 2025
Merged via the queue into rust-lang:master with commit 445d419 Jul 30, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 30, 2025
@profetia profetia deleted the issue14981 branch September 12, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iter-on-single-items breaks code in macro context that takes IntoIterator

7 participants

@profetia @rustbot @samueltardieu @blyxyas @Jarcho @y21 @dswij