Skip to content

Fix redundant_closure suggests wrongly with deref overload #15077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

Fix redundant_closure suggests wrongly with deref overload #15077

merged 1 commit into from
Aug 29, 2025
+130 −9

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jun 18, 2025 •
edited by rustbot
Loading

Closes #15072

changelog: [redundant_closure] fix wrong suggestions with deref overload

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 18, 2025
samueltardieu
samueltardieu previously requested changes Jun 18, 2025
View reviewed changes
@profetia profetia requested a review from samueltardieu June 19, 2025 12:50
@samueltardieu samueltardieu dismissed their stale review June 20, 2025 09:35

Changes done

@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned dswij and unassigned y21 Jul 14, 2025
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned Jarcho and unassigned dswij Aug 11, 2025
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned Centri3 and unassigned Jarcho Aug 29, 2025
@dswij
Copy link
Member

dswij commented Aug 29, 2025

Thank you!

@dswij dswij added this pull request to the merge queue Aug 29, 2025
Merged via the queue into rust-lang:master with commit 2badfe8 Aug 29, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 29, 2025
@profetia profetia deleted the issue15072 branch September 12, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dswij dswij dswij approved these changes

@samueltardieu samueltardieu Awaiting requested review from samueltardieu

Assignees

@Centri3 Centri3

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clippy --fix redundant closure breaks with function call through deref

7 participants

@profetia @rustbot @dswij @samueltardieu @Jarcho @y21 @Centri3