Skip to content

Fix large_stack_frames FP on compiler generated targets #15101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blyxyas merged 1 commit into from
Dec 1, 2025
Merged

Fix large_stack_frames FP on compiler generated targets #15101

blyxyas merged 1 commit into from
Dec 1, 2025

Conversation

@profetia
Copy link
Member

@profetia profetia commented Jun 22, 2025 •
edited by rustbot
Loading

Closes #15099

The compiler will generate a special main function for the tests, which caused this FP.

changelog: [large_stack_frames] fix FP on compiler generated targets

@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 22, 2025
samueltardieu
samueltardieu requested changes Jun 22, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 22, 2025
@profetia profetia requested a review from samueltardieu June 22, 2025 08:37
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 22, 2025
samueltardieu

This comment was marked as duplicate.

Sign in to view

samueltardieu
samueltardieu previously requested changes Jun 22, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 22, 2025
@y21 y21 mentioned this pull request Jun 22, 2025
Closed
@LebedevRI
Copy link

LebedevRI commented Jun 22, 2025

@profetia @samueltardieu @y21 thank you!

@rustbot rustbot assigned y21 and unassigned samueltardieu Jun 26, 2025
@samueltardieu samueltardieu dismissed their stale review June 26, 2025 08:50

Reassigned

y21
y21 reviewed Jun 26, 2025
View reviewed changes
@profetia profetia force-pushed the issue15099 branch 2 times, most recently from ce992be to 4ddb621 Compare July 13, 2025 09:57
@profetia
Copy link
Member Author

profetia commented Jul 13, 2025

@y21 I've updated this PR based on the above discussions:

  • A new lint_inside_tests option is added to determine whether to lint inside test modules.
  • A new lint_macro_generated_functions option is added to determine whehter to lint macro generated functions. When giving such lint, it will happen on the macro call span that generated the function, and tell the user about that.

@profetia profetia requested a review from y21 July 13, 2025 10:01
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jul 13, 2025
@github-actions
Copy link

github-actions bot commented Jul 13, 2025 •
edited
Loading

Lintcheck changes for 1b76a34

Lint Added Removed Changed
clippy::large_stack_frames 15 15 0

This comment will be updated if you push new changes

y21
y21 reviewed Jul 13, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure about the newly added configuration options, mostly because I can't see a use case for them and it complicates clippy. I'd have much more preferred the initial version of the PR which was much simpler.

@profetia
Copy link
Member Author

profetia commented Nov 25, 2025

r? clippy

@rustbot rustbot assigned blyxyas and unassigned Alexendoo Nov 25, 2025
blyxyas
blyxyas requested changes Nov 26, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, and this is looking great!

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@profetia profetia requested a review from blyxyas November 27, 2025 00:21
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Nov 27, 2025
blyxyas
blyxyas requested changes Nov 28, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 28, 2025
@profetia profetia requested a review from blyxyas November 29, 2025 22:22
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Nov 29, 2025
blyxyas
blyxyas approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this great contribution!

View changes since this review

@blyxyas blyxyas added this pull request to the merge queue Dec 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 1, 2025
@profetia
Copy link
Member Author

profetia commented Dec 1, 2025

@blyxyas The test still failed on i386 target due to size difference. I've set the test to ignore i386 entirely

@profetia profetia requested a review from blyxyas December 1, 2025 18:04
@blyxyas blyxyas added this pull request to the merge queue Dec 1, 2025
Merged via the queue into rust-lang:master with commit 21c5ddd Dec 1, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu left review comments

@Alexendoo Alexendoo Alexendoo left review comments

@y21 y21 Awaiting requested review from y21

@flip1995 flip1995 Awaiting requested review from flip1995

@blyxyas blyxyas Awaiting requested review from blyxyas

Assignees

@blyxyas blyxyas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

large_stack_frames: unsilenceable diagnostic about compiler-generated functions

9 participants

@profetia @rustbot @LebedevRI @samueltardieu @Alexendoo @flip1995 @y21 @blyxyas @llogiq